search

iris-hep / analysis-grand-challenge

Repository dedicated to AGC preparations & execution
https://agc.readthedocs.io
MIT License
24 stars 39 forks source link

CMS example with ServiceX 3 client #225

Closed ponyisi closed 2 weeks ago

ponyisi commented 2 months ago

This works with uproot-raw right now with servicex==3.0.0b1. The func_adl version does not yet work (@gordonwatts is working on this), and in the end we would want a version with the final 3.0.0 release.

ponyisi commented 2 months ago

I've pushed the fixes for the func_adl version of the CMS notebook, with fixes courtesy of @gordonwatts (this needs func_adl >= 3.3.3).

I would like to update the ATLAS example as well, but it seems that at the moment there are problems with the UNL storage which prevent me from accessing those files.

ponyisi commented 2 months ago

I have updated the ATLAS examples.

alexander-held commented 1 month ago

The issue with the CI complaining about unrelated files should be fixable by rebasing to incorporate #226.

alexander-held commented 1 month ago

In the CMS ttbar notebook after the ServiceX delivery cell I see

Method Zip not found on object <class 'types.dict_dataclass'>

What is this about?

alexander-held commented 1 month ago

Other than the small things about imports above, could we please keep ServiceX off by default with USE_SERVICEX = FALSE to make the notebook work by default with the least amount of dependencies?

One more very picky request: could we please move USE_SERVICEX_DOWNLOAD into utils/config.py (probably into the global section) in an attempt to limit the amount of things to be configured in the notebook directly?

ponyisi commented 1 month ago

In the CMS ttbar notebook after the ServiceX delivery cell I see

Method Zip not found on object <class 'types.dict_dataclass'>

What is this about?

This is a particular issue related to how func_adl interprets the query, I know @gordonwatts is looking into it.