search

iris-hep / func_adl_xAOD

Client interface to send a hierarchical SQL-like query to an xAOD backend
0 stars 5 forks source link

gordonwatts/issue157 #160

Closed gordonwatts closed 3 years ago

gordonwatts commented 3 years ago

Add CMS' isNonnull - which is a special call on a TrackRef, and not on the Track object, which mostly confuses the func_adl xAOD object model assumptions.

codecov[bot] commented 3 years ago

Codecov Report

Merging #160 (3898b23) into master (e44b599) will increase coverage by 0.91%. The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   89.97%   90.88%   +0.91%     
==========================================
  Files          23       25       +2     
  Lines        1297     1317      +20     
  Branches      141      143       +2     
==========================================
+ Hits         1167     1197      +30     
+ Misses        100       89      -11     
- Partials       30       31       +1
Flag Coverage Δ
unittests 90.88% <90.47%> (+0.91%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
func_adl_xAOD/cms/aod/cms_functions.py 87.50% <87.50%> (ø)
func_adl_xAOD/cms/aod/__init__.py 100.00% <100.00%> (ø)
func_adl_xAOD/cms/aod/executor.py 92.85% <100.00%> (+38.31%) :arrow_up:
func_adl_xAOD/cms/aod/event_collections.py 82.60% <0.00%> (+4.34%) :arrow_up:
func_adl_xAOD/cms/aod/query_ast_visitor.py 79.16% <0.00%> (+29.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e44b599...3898b23. Read the comment docs.