Closed gordonwatts closed 4 months ago
Attention: Patch coverage is 93.92265%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 95.05%. Comparing base (
6e725f0
) to head (2f12ed4
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
enums
now supported by the C++ backend.qastle
were requiredenums
are referenced as Pythonenums
fund_adl
queries.A change like this is rather extensive. It would be nice if the design was such that adding a feature like this was localized to a file or two.
Changes
type
to supportenums
define_num
metadata` to get the enum defined, and allow setting of a tree type metadataDiscussion
This is a "change" from what we usually do because an enum can be referenced as an argument so the user has to explicitly reference it - it isn't something that hangs off a EventDataSet or similar object.
cpp_value
One thing discovered while working with this: we do not want to add "special" information for adding an include file. This should occur when the func_adl types are generated.
Minor
pylance
,flake8
, andblack
errors in a bunch of files!ci.yaml
for more modernsetup-python
and also removing 3.7 support.Fixes #218