search

iris-hep / idap-200gbps-atlas

benchmarking throughput with PHYSLITE
6 stars 1 forks source link

Get a new version of AB-dev with the new func_adl #60

Closed gordonwatts closed 4 months ago

gordonwatts commented 4 months ago

The latest version of the func_adl package is needed to run the current code. Version 3.3.1. If that could be put into AB-dev on UChicago that would be great!

gordonwatts commented 4 months ago

Ok - this is stuck by the same questions as issue #41. When that is resolved, this can move forward.

matthewfeickert commented 4 months ago

@gordonwatts As there is currently no version of func-adl supplied in the AB-dev image (as of https://github.com/usatlas/analysisbase-dask/commit/53366ea8fe967dba192abf70c7fca6c48106b5ed) is there any benefit of having func-adl by itself in AB-dev available now? If so, I'll transfer this to https://github.com/usatlas/analysisbase-dask/issues and take care of this now. If this is just to interact with the servicex client then I guess we can leave this to get naturally resolved by Issue #41 and https://github.com/ssl-hep/ServiceX_frontend/issues/363, which would pull in the latest version of func-adl by default.

gordonwatts commented 4 months ago

Ok - @ivukotic got this done, thanks!!!

matthewfeickert commented 4 months ago

Ok - @ivukotic got this done, thanks!!!

This is bad actually? If @ivukotic added the current servicex to AB-dev then he just broke other stuff. This should be reverted.

matthewfeickert commented 4 months ago

Oh. https://github.com/usatlas/analysisbase-dask/commit/31d8d2ebd1ee3534e206eef0112af45fc5374ebc doesn't do what this issue asks for. It installs the old version of the serviceX client. So things don't break as this version doesn't use pydantic at all, but also not useful I think.

matthewfeickert commented 4 months ago

Oh. https://github.com/usatlas/analysisbase-dask/commit/31d8d2ebd1ee3534e206eef0112af45fc5374ebc doesn't do what this issue asks for

No, I was wrong, it does do this, for _funcadl only. But let's leave this Issue open as once https://github.com/ssl-hep/ServiceX_frontend/pull/368 has been merged and Ben cuts a new release the whole of AB-dev can be updated to get the new servicex and func-adl.

matthewfeickert commented 4 months ago

Reclosing given https://github.com/usatlas/analysisbase-dask/pull/47. The original Issue requirements were addressed by https://github.com/usatlas/analysisbase-dask/commit/31d8d2ebd1ee3534e206eef0112af45fc5374ebc, and https://github.com/usatlas/analysisbase-dask/pull/47 just updates ServiceX to the pydantic v2 version.