search

iris-ua / iris_lama

LaMa - A Localization and Mapping library
BSD 3-Clause "New" or "Revised" License
337 stars 72 forks source link

Shared library #13

Closed reinzor closed 4 years ago

reinzor commented 4 years ago

Any reason why iris-lama is a static library (https://github.com/iris-ua/iris_lama/blob/master/src/CMakeLists.txt#L54) and no shared library?

AFAIK, catkin_package depend is not possible with this library. Why is it different then for example octomap?

facontidavide commented 4 years ago

I have a little trick that I use sometime to create a CMakeLists.txt file that work both with catkin or without it. In this way it would be easier to "catkinize" for ROS users and still be ROS independent.

@eupedrosa do you want to have a look to a potential PR?

eupedrosa commented 4 years ago

Hi @reinzor , There is no reason for iris-lamato be a static library. It is some sort of legacy decision that I already forgot. I have no problems in switching to a shared library.

@facontidavide, your PR breaks https://github.com/iris-ua/iris_lama_ros, but that is OK. I will accept the commit and provide the necessary changes to the ros package.

reinzor commented 4 years ago

That was quick, thanks @eupedrosa and @facontidavide !