search

iris-ua / iris_lama

LaMa - A Localization and Mapping library
BSD 3-Clause "New" or "Revised" License
336 stars 72 forks source link

Catkinize the library #14

Closed facontidavide closed 4 years ago

facontidavide commented 4 years ago

This PR address a concern that I have and was mentioned in #13.

iris_lama haven't published yet a binary for ROS. This means that people need to compile it from source to test it.

I think one of the limitations to do that is that iris_lama must be correctly "catkinized". At the same time, I agree with you in keeping this library ROS independent.

I had to face the same problem with BehaviorTree.CPP.

In this PR you can find a little trick to to detect catkin in cmake.

Note that if you decide to merge this PR, I will need to also update accordingly iris_lama_ros.