search

iris-ua / iris_lama

LaMa - A Localization and Mapping library
BSD 3-Clause "New" or "Revised" License
336 stars 72 forks source link

Use LZ4 library from ROS when available #7

Closed facontidavide closed 5 years ago

facontidavide commented 5 years ago

This is related to the problem reported here: https://github.com/iris-ua/iris_lama_ros/pull/2

There might be other solutions, of course

facontidavide commented 5 years ago

Bad news... this is not the problem. I have tried to get rid of the external dependency and use instead, but the problem persists...

eupedrosa commented 5 years ago

What version of ROS you are using @facontidavide? I've tried to reproduce the error reported at https://github.com/iris-ua/iris_lama_ros/pull/2 but it worked fine. I am using ROS Melodic.

facontidavide commented 5 years ago

REOPENED.

I am working in Kinetic and I confirm the issue, unfortunately.

facontidavide commented 5 years ago

laser_lz4.bag.zip

Just in case, this is my rosbag

eupedrosa commented 5 years ago

I just tested the code in a machine with Kinetic. I have the same problem, it crashes.

eupedrosa commented 5 years ago

I found the problem. The culprit is zstd and not lz4, more specifically extern/zstd/xxhash.c. This is an easy fix. I will push the changes.

facontidavide commented 5 years ago

Great