search

iriscouch / browser-request

Browser library compatible with Node.js request package
Apache License 2.0
360 stars 102 forks source link

fix setRequestHeaders for IE #40

Open matiu opened 9 years ago

matiu commented 9 years ago

Fix setRequestHeaders for IE

yemel commented 9 years ago

+1

pine commented 9 years ago

:+1:

Pomax commented 9 years ago

@iriscouch can you please just merge this in and push a new version up? It's been a while, and this patch still fixes a critical bug in your code. Especially if this lib is no longer maintained, it'll be worth doing.

PavelGavlik commented 9 years ago

+1 This fixes a critial bug, which is present also in current Chrome.

guillaume-duchemin commented 9 years ago

+1 especially for >= IE 10

DCKT commented 8 years ago

Hi, no plan to merge this ? Thanks for your work :)

Pomax commented 8 years ago

Given that there has been no movement on this for over a year, we can safely assume this repo has been abandoned. Better alternatives (as of March 2016) are superagent (established as the clear winner between request, browser-request, etc) and node-fetch (an implementation of the Fetch API)