iriscouch / browser-request

Browser library compatible with Node.js request package
Apache License 2.0
360 stars 102 forks source link

Basic Auth Base64 endocding #47

Open ximex opened 9 years ago

ximex commented 9 years ago

There is a problem with usernames/passwords with special chars like ä,ö,ü.

The problem is this part: https://github.com/iriscouch/browser-request/blob/master/index.js#L433-L472

If i take the function from the original request lib it works: https://github.com/request/request/blob/master/lib/helpers.js#L45-L47