iriscouch / build-couchdb

Batteries-included CouchDB build system
227 stars 36 forks source link

LinuxMint 11 support and "no distro" detection #31

Closed wulftone closed 12 years ago

wulftone commented 12 years ago

added support for LinuxMint and tested install on LinuxMint 11 (gnome) also made it raise an error if no distro detected

jhs commented 12 years ago

Interesting. Does just rake work, or does the full CouchDB build work?

davidsansome commented 12 years ago

It's just rake that doesn't work - it fails immediately with:

[david@hoover (master) ~/src/build-couchdb] rake --trace
(in /home/david/src/build-couchdb)
rake aborted!
undefined method `[]' for nil:NilClass
/home/david/src/build-couchdb/tasks/lib/package_dep.rb:23:in `package_dep'
/home/david/src/build-couchdb/tasks/toolchain.rake:13
/home/david/src/build-couchdb/tasks/toolchain.rake:9:in `each'
/home/david/src/build-couchdb/tasks/toolchain.rake:9
/usr/lib/ruby/1.8/rake.rb:1882:in `in_namespace'
/usr/lib/ruby/1.8/rake.rb:910:in `namespace'
/home/david/src/build-couchdb/tasks/toolchain.rake:6
/usr/lib/ruby/1.8/rake.rb:1620:in `load'
/usr/lib/ruby/1.8/rake.rb:1620:in `load'
/usr/lib/ruby/1.8/rake.rb:2451:in `load_imports'
/usr/lib/ruby/1.8/rake.rb:2390:in `raw_load_rakefile'
/usr/lib/ruby/1.8/rake.rb:2017:in `load_rakefile'
/usr/lib/ruby/1.8/rake.rb:2068:in `standard_exception_handling'
/usr/lib/ruby/1.8/rake.rb:2016:in `load_rakefile'
/usr/lib/ruby/1.8/rake.rb:2000:in `run'
/usr/lib/ruby/1.8/rake.rb:2068:in `standard_exception_handling'
/usr/lib/ruby/1.8/rake.rb:1998:in `run'
/usr/bin/rake:28

detect_distro() returns nil because Linux Mint has both /etc/lsb-release and /etc/debian_version files, but /etc/lsb-release doesn't contain "Ubuntu", so none of the checks in detect_distro() match.

I can confirm that this patch fixes the error for me on Mint 12 - it would be very useful if it was merged.