iriscouch / follow

Very stable, very reliable, NodeJS CouchDB _changes follower
Apache License 2.0
393 stars 82 forks source link

exception in feed.js #1

Closed mark-hahn closed 13 years ago

mark-hahn commented 13 years ago

I got an exception in line 326 of feed.js ...

self.log.warn('Closing req ' + self.pending.request.id() + ' for timeout after ' + elapsed_ms + 'ms; heartbeat=' + self.heartbeat);

self.pending.request was null so I got ...

[{"stack":"TypeError: Cannot call method 'id' of null
    at Feed.on_timeout (/opt/node/comps2/dev/node_modules/follow/feed.js:326:55)
at Object._onTimeout (/opt/node/comps2/dev/node_modules/follow/feed.js:274:58)
at Timer.callback (timers.js:83:39)","arguments":["id",null],"type":"non_object_property_call","message":"Cannot call method 'id' of    null"}]

This is in production code but my code could be bad of course.

jhs commented 13 years ago

Hi! Sorry for the delay. I missed many GitHub notifications, as they were sent to an old email address.

This bug should be fixed in the master branch and in the NPM package v0.2.0. Please let me know if you have any other issues. Thanks!

mark-hahn commented 13 years ago

I'll check this out tomorrow...