search

iriscouch / follow

Very stable, very reliable, NodeJS CouchDB _changes follower
Apache License 2.0
393 stars 82 forks source link

Added options for heartbeat, max_retry_seconds, initial_retry_delay, response_grace_time #64

Closed grimborg closed 9 years ago

grimborg commented 9 years ago

I needed to configure the retry delay, which can't be done without changes as the query method overrides it, so I've added an option for it on the constructor. I've also made the other parameters configurable, in order to have consistency (before, some parameters were passed as options, others had to be modified when the feed instance was already created).

Some of these settings are in seconds and others are in milliseconds, which is messy and error-prone. I haven't changed that so as to keep the change small and backwards compatible.

jcrugzz commented 9 years ago

@grimborg yea this part of the logic could use a cleanup but thanks for the backwards compatible change!