search

irisfofs / jekyll-rp_logs

Jeykll plugin to turn raw IRC logs into pretty pages.
https://andrew.rs/projects/jekyll-rp_logs/
MIT License
3 stars 6 forks source link

Move RP formatting to Liquid templates #57

Closed irisfofs closed 8 years ago

irisfofs commented 8 years ago

Instead of generating the output (oodles and oodles of <p> tags) with Ruby, we could pass the list of LogLines into the page and use a Liquid template to generate the output.

This would let it be more user-configurable, and also use Liquid for what it's meant to do.

irisfofs commented 8 years ago

So this revealed that using Liquid to generate the RP pages is actually really, really slow. Much slower than generating it with Ruby, the previous approach.

It's more expressive and is actually user-editable, but it seems like it might not be worth it.

Reopening this to have the changes moved into their own feature branch, to be potentially readded later.

irisfofs commented 8 years ago

Jekyll 3.1 renders it in around 60% of the time, but it's still very slow.

irisfofs commented 8 years ago

Here's some rough timing, using some "representative sample data" (the collection of 138 RPs currently on my own site):

Jekyll  Liquid  Time
------  ------  ----
v3.1    Yes     23 s
v2.5.3  Yes     37 s
v2.5.3  No       9 s

Also note that using Jekyll v3.1 is currently not supported (see #66). So the options are keep the current, slightly icky Ruby based generation, or multiply build times by 4.

irisfofs commented 8 years ago

The Liquid formatter lives in the feature/liquid-gen-rp-pages branch now. This doesn't necessarily make any sense but that's okay. Could/should maybe have been a tag.