search

irisnet / irismod

Reusable modules contributed or optimized by the IRISnet project.
Apache License 2.0
42 stars 31 forks source link

Can the IrisNet NFT module be used for new chains, or can a PR be made to get it into the main cosmos/cosmos-sdk/x/nft implementation? #406

Open Tectract opened 5 months ago

Tectract commented 5 months ago

Hi there, my team is working on getting NFTs working on a new Cosmos SDK ignite chain testnet.

Is it possible to just fork the x/nft repository from IrisNet or do we need some other pieces too, like... errormod?

Is this a working NFT implementation? If so, could you guys make a PR to get it into the main cosmos-sdk/x/nft branch because they seem to need dire help in getting their NFT solution working...

dreamer-zq commented 5 months ago

@Tectract First of all, the x/nft module already exists in cosmos (although it cannot be used directly). In order to allow users to expand more flexibly, we may not consider merging the nft in irismod directly into cosmos for the specific implementation of nft. In fact, irismod is completely open source code, users can fork it

Tectract commented 5 months ago

The problem is that the x/nft module in the official repo ONLY includes the "send" command, meaning you cannot use it to actually mint NFTs in any way, shape, or form. That's why we need some more fleshed-out NFT code like from your repo to be pulled upstream, guys. But don't worry we found more up-to-date code in the Coreon blockchain repo ;)

although it cannot be used directly

What is the point of an NFT module that cannot mint an NFT? Is this a joke???

dreamer-zq commented 5 months ago

The problem is that the x/nft module in the official repo ONLY includes the "send" command, meaning you cannot use it to actually mint NFTs in any way, shape, or form. That's why we need some more fleshed-out NFT code like from your repo to be pulled upstream, guys. But don't worry we found more up-to-date code in the Coreon blockchain repo ;)

although it cannot be used directly

What is the point of an NFT module that cannot mint an NFT? Is this a joke???

You can understand that x/nft only defines the specifications of the storage layer and the data structure of nft. The api layer is completely implemented by the user, which is also to bring greater flexibility.

Tectract commented 5 months ago

The api layer is completely implemented by the user

Except this means that there is no standard NFT implementation across chains in the Interchain, and it means that when a user spins up a new chain using Ignite, they have no way to use NFTs on their new chain, and there is no way to spin up a Cosmos node and mint NFTs using it. This is why ATOM is still at $8 and Solana is a $150. You want to make your ATOM holdings go up by 10x? Help us get a standardized NFT implementation into the main Cosmos SDK chains.

Besides, why would any user need a custom NFT implementation? It is a standard strictly defined by a protocol.