search

iriusrisk / GoCD-EC2-Elastic-Agent-Plugin

Plugin for GoCD server that will spin up and shut down EC2 instances as its agent workers on demand
Apache License 2.0
12 stars 12 forks source link

remove "required" flag from authentication parameters in EC2 #12

Closed brettcave closed 4 years ago

brettcave commented 4 years ago

If GoCD is running in EC2, and the GoCD instance has an instance profile, it may not need explicit key and secret. Allow these to be left blank, so the AWS SDK can fall back on iam instance profile authentication.

v-sky commented 4 years ago

Makes sense to me, related with your previous pull request #11

brettcave commented 4 years ago

I just picked up a bug on #11 this @v-sky - the AWS Access Key Id requires a value to be entered, but as long as the secret access is blank, it will still use default credentials.

The EA config screen doesn't throw errors when leaving it blank, but when instance provisioning is attempted, the console indicates that this should not be blank.

v-sky commented 4 years ago

Feature reviewed and tested on GoCD server 20.4. Will be included into the next release.