Allow custom tags to be added to EC2 instances (in AWS)

[brettcave]

The plugin sets some default tags on instances. Allow additional custom tags to be set.

[brettcave]

https://github.com/brettcave/GoCD-EC2-Elastic-Agent-Plugin/pull/1/commits/25c93bf684bdde6f0fe9f969b66e77b09c06d022 allows custom tags. There's no test for this and no strong input validation though.

[GregYeo]

brettcave@25c93bf LGTM.

I'd recommend you'd make Pull Request instead of putting Issue to be progressed.

Tags are important resource for big size company. They are used for checking billing and grouping resource for DevOps. In terms of the operation, manageable tags are great idea.

If you could, I'd like to attach additional controlling for the tags that basic tags below

https://github.com/brettcave/GoCD-EC2-Elastic-Agent-Plugin/blob/25c93bf684bdde6f0fe9f969b66e77b09c06d022/src/main/java/com/continuumsecurity/elasticagent/ec2/Ec2Instance.java#L148-L157

• tagName
• tagType
• tagPipelineName
• tagPipelineCounter
• tagPipelineLabel
• tagStageName
• tagStageCounter
• tagJobName
• tagJobId
• tagJsonJobIdentifier

are overwritable by adding same tag key in Input Form or removable by selecting Checkbox. I'm not sure your code is already able to overwrite. I did not confirm it.

Sometimes, Unnecessary tags or uncontrollable tags are increasing management cost.

Although you do not implement it, i think brettcave@25c93bf is still nice implementation.