iriusrisk / GoCD-EC2-Elastic-Agent-Plugin

Plugin for GoCD server that will spin up and shut down EC2 instances as its agent workers on demand
Apache License 2.0
12 stars 12 forks source link

Correct environment support + upgrade dependencies #25

Open chadlwilson opened 5 months ago

chadlwilson commented 5 months ago

Fixes #20 by ensuring the GoCD-instructed environment is auto-registered by the agent. The plugin currently breaks the contract with GoCD which causes some confusion for users; see https://groups.google.com/g/go-cd/c/PAzY8Cw7Mxk/m/9Hbj8Fp9BAAJ

The fix is pretty simple given the current plugin design. Note that this change adds a warning in the job log if users have used the previous hacks to try and get environment support to work.

Also

chadlwilson commented 5 months ago

@adrian-iriusrisk Is this something you're willing to evaluate and merge? PR looks a little big due to rationalising/removing commons-lang and some other dependencies that came over from the plugin template this was based on, but it should be reasonably straightforward. 🙏