iriusrisk / OpenThreatModel

The Open Threat Modeling Format (OTM) defines a platform independent way to define the threat model of any system.
165 stars 13 forks source link

Update otm_schema.json #17

Closed Ogglas closed 1 year ago

Ogglas commented 1 year ago

Schema from PR https://github.com/iriusrisk/OpenThreatModel/pull/15, that is a direct copy from https://github.com/iriusrisk/startleft/blob/main/otm/resources/schemas/otm_schema.json, does not validate correctly in some implementations and otmVersion was not specified in the schema as a property before.

image

image

With these changes the schema validates correctly.

https://www.liquid-technologies.com/online-json-schema-validator

https://jsonschemalint.com/#!/version/draft-07/markup/json

daFont-iriusrisk commented 1 year ago

Good morning @Ogglas

As we talked before in #15 we have to handle some improvements created on startleft repository for the schema.

So we have to bring those changes to this repo, them handle your PR and after that the source of truth for the schema will be in this repo

Once we "move" the schema all the changes have to be made in this repo and then use the schema in another projects.

Give us some time to put some order here :)

Thanks again for your efforts to improve Open Threat Modeling format.

Ogglas commented 1 year ago

@daFont-iriusrisk sounds good! I will add the same PR to the startleft repo if you want to incorporate the changes there first.

daFont-iriusrisk commented 1 year ago

This changes was included through https://github.com/iriusrisk/OpenThreatModel/pull/18

Thank you @Ogglas for your patience and your contributions 😃