Strict compiling of schema produces warnings

jgadsden commented 8 months ago

When compiling the OTM schema using ajv version 8.11.0 in strict mode (which is the default) we get the following warnings

strict mode: missing type "object" for keyword "required" at "https://iriusrisk.com/schema/otm-0.2.0.schema.json#/properties/representations" (strictTypes)
strict mode: missing type "object" for keyword "properties" at "https://iriusrisk.com/schema/otm-0.2.0.schema.json#/properties/representations" (strictTypes)
strict mode: missing type "object" for keyword "required" at "https://iriusrisk.com/schema/otm-0.2.0.schema.json#/properties/assets" (strictTypes)
strict mode: missing type "object" for keyword "properties" at "https://iriusrisk.com/schema/otm-0.2.0.schema.json#/properties/assets" (strictTypes)

jgadsden commented 8 months ago

The reason for the warnings is because 'representations' and 'assets' are defined as arrays but not as arrays of objects

dantolin-iriusrisk commented 8 months ago

Hi, @jgadsden! Thank you for the warning. We'll do the change to keep it clean.

jgadsden commented 8 months ago

OK, do you want me to contribute? Or I can leave it with you

dantolin-iriusrisk commented 8 months ago

As you have the change well identified, feel free to contribute, of course!

iriusrisk / OpenThreatModel