iriusrisk / startleft

StartLeft is an automation tool for generating Threat Models written in the Open Threat Model (OTM) format from a variety of different sources such as IaC files, diagrams or projects exported from Threat Modelling tools.
https://iriusrisk.github.io/startleft/
Apache License 2.0
48 stars 13 forks source link

New Abacus SLP module implemented #353

Closed repo-2017 closed 5 months ago

dantolin-iriusrisk commented 8 months ago

@repo-2017 Apart from the code comments, it is important to create a minimum set of tests for the new parser. You can take drawio as a reference. Usually, we create a couple of integration tests with relevant use cases (basically a happy path) and then unit tests for all the classes with the slp logic. In this case, as you have copied some classes from drawio (DefaultMappingTransformer, DiagramMapper, etc.), you can simply copy the tests as well. For those new classes (AbacusParser, for example), you should create some minimum unit tests.