irllabs / archive_socialvr-browser

1 stars 0 forks source link

Preview mode - visibility of hotspots #59

Open apuhub opened 6 years ago

apuhub commented 6 years ago

Needs a better contrast (drop shadow/something). Dotted lines difficult to identify white on white.

apuhub commented 6 years ago

@mericda is this closed now? Can you go through your issues and close the ones that are finalized?

apuhub commented 6 years ago

We need drop shadows or something to differentiate between the background. Other ideas on graphics @batchku ?

apuhub commented 6 years ago

@mericda @batchku can you update this topic

mericda commented 6 years ago

@emilt27 is it possible to emulate a drop shadow effect on three.js to solve this issue?

apuhub commented 6 years ago

@emilt27 @jerichozis how can we improve this now that we have shifted to aframe?

jerichozis commented 6 years ago

@apuhub i think most performant and simple solution is to just add more gradual shading to hotspot marker images.

emilt27 commented 6 years ago
screen shot 2018-07-16 at 2 58 53 pm screen shot 2018-07-16 at 3 03 04 pm

@apuhub, @mericda In my opinion, it is looking OK. But if you like to add more shadows, I agree with @jerichozis, it is better to add it to marker images.

jerichozis commented 6 years ago

@apuhub @mericda but i would recommend to use black(or grey) solid borders instead of shadows in order to avoid this kind of experience (screenshot taken from staging) image

jerichozis commented 6 years ago

You see that one image lays on another despite opacity of shadows. Thats because texture opacity behavior is a bit different.

There is no such experience on aframe if i set alpha-test value (see picture) but this alpha test will swallow shadows. So i recommend to consider to refuse using shadows in favor of borders. image

apuhub commented 6 years ago

@batchku @mericda can you help with this?

mericda commented 6 years ago

@jerichozis to solve the issue in your latest screenshot, is it possible to define a safe area around a hotspot so that this wouldn't happen programmatically? No matter what we visually design, I think we shouldn't allow adding hotspots that close to each other. It'd solve this issue and we can have our shadows back 🤓