search

irllabs / ml-lib

A machine learning library for Max and Pure Data
Other
275 stars 40 forks source link

ml.mlp missing, ml.hmmc typo, leapmotion and osc-route dependencies, bogus nothing #159

Closed lesstuck closed 5 years ago

lesstuck commented 5 years ago

Hi Jamie & Ali,

Thanks for the fab package!

• It seems that the ml.mlp object did not make it to the release.

• Also, there's a typo in the launcher. A message box refers to ml.hmm, not ml.hmmc. Were you trying to hide your Markov model?

• The leapmotion and beloved osc-route objects require other packages. Might be nice to include a note?

• And there is a bogus object box called, appropriately, "nothing".

Looking forward to more fun and games with your awesome work, Les

jamiebullock commented 5 years ago

Hi @lesstuck

Thanks for the valuable feedback!

Replying to your issues:

• It seems that the ml.mlp object did not make it to the release.

We renamed ml.mlp to ml.ann to avoid naming conflicts with other libraries, but it looks like we didn't update the package info.

• Also, there's a typo in the launcher. A message box refers to ml.hmm, not ml.hmmc. Were you trying to hide your Markov model?

Same as above.

• The leapmotion and beloved osc-route objects require other packages. Might be nice to include a note?

@NiccoloGranieri can you add a separate issue to look into the examples and link the issue back here in a comment

• And there is a bogus object box called, appropriately, "nothing".

Is this in the master patch or in one of the object-specific help files?

jamiebullock commented 5 years ago

OK... there's a new release here which should fix the hmm / map naming issues

@lesstuck can you confirm?

Also, is the "nothing" still there?

NiccoloGranieri commented 5 years ago

Review examples shipped with ml-lib v1.0

lesstuck commented 5 years ago

All the naming problems in the launcher and help files have been fixed.

There are still some problems in both Example 3 "Multidimensional Mapping with MLP" and in in Example 4 "Leap Multidimensional Mapping": • Top-level patcher still has ml.mlp instead of ml.ann • subpatcher paf~ inside subpatcher soundz still has the mysterious nothing abstraction

and it looks like Niccolo is on the osc-route and leapmotion dependency train.

NiccoloGranieri commented 5 years ago

Hi @lesstuck, thanks for providing so much insight on the latest release of ml-lib! I will add the two additional notes about the examples to the referenced issue, as I will be dealing with the example side of things. Let me know if you spot anything else!

jamiebullock commented 5 years ago

Thanks. I'm closing this now as the remaining issues are covered by #160