search

irllabs / roundaround

2 stars 0 forks source link

Remove ... from top right of app and add fullscreen/tempo to top bar #123

Open deerwolf opened 3 years ago

deerwolf commented 3 years ago

2021-08-14_12-39-06

deerwolf commented 3 years ago

I think the tempo slider can be about 30% smaller.

deerwolf commented 3 years ago

Sorry was not clear here, it is just the slider that needs to be smaller. It looks like the "tempo" text is now smaller along with the slider UI. The slider can just be about 30% shorter in length.

Also, the fullscreen button should exit fullscreen when clicked a second time.

deerwolf commented 3 years ago

Size of tempo slider looks good but the slider should be center justified so it sits in the middle of the top panel (currently sits at bottom).
Screen Shot 2021-08-18 at 9 53 22 AM

Also this is still not fixed: the fullscreen button should exit fullscreen when clicked a second time.

batchku commented 3 years ago
  1. Remove drop-let pbm number
  2. Move slider up and vertically center with other top bar elements
  3. Add PBM number as new UI element between "Play" and "Slider"; same font size/type as "Share"; vertically centered
  4. Fullscreen - UNDO not working on safara/ios
deerwolf commented 3 years ago

You can remove the droplet above the slider showing the value as it gets cut off (see image).

Also, keep the original label "Tempo" and display to left of your new tempo value UI element.

Also, Fullscreen undo still not working on Safari

deerwolf commented 3 years ago

Can you please change label to "Tempo:"

Also, exiting fullscreen by clicking the fullscreen button still not working on safari.

batchku commented 3 years ago

Done: removal of modal Done: safari out-of-fullscreen Done: new tempo slider

problem: There is a glitch where during application l load we see a top bar that does NOT have the tempo slider for a short momenht, and then it updates.

See video below:

batchku commented 3 years ago

https://user-images.githubusercontent.com/518356/130123361-c17870a7-fdb7-42c5-8e81-060a9bf721ca.mp4