irlnathan / activityoverlord20

This is an update to activityOverlord.
158 stars 52 forks source link

Uncaught error and compareTo issue #3

Closed misterch0c closed 9 years ago

misterch0c commented 9 years ago

Firstly thanks a lot for this. I've followed the video and I have 2 little issues. Uncaught Error: [$injector:modulerr] http://errors.angularjs.org/1.2.12/$injector/modulerr?p0=SignupModule&p1=Er…p%3A%2F %2Flocalhost%3A1337%2Fjs%2Fdependencies%2Fangular.min.js%3A17%3A431) The error link redirects me to this page so I included ngRoute but error is still here. The page allo says:

This error can also occur if you have tried to add your own components to the ng module. This has never been supported and from 1.3.0 it will actually trigger this error. For instance the following code could trigger this error. angular.module('ng').filter('tel', function (){});

So maybe it's just the wrong way to do it?

I got previous error and one thing that I had to do and was not coverd in the video angular.min.js etc At the end I have this:

    <script src="/js/dependencies/sails.io.js"></script>
    <script src="/js/dependencies/angular1.3.js"></script>
    <script src="/js/dependencies/angular.min.js"></script>
    <script src="/js/dependencies/angular-route.js"></script>
    <script src="/js/dependencies/angular-route.min.js"></script>
    <script src="/js/dependencies/angular-toastr.js"></script>
    <script src="/js/dependencies/compareTo.module.js"></script>
    <script src="/js/public/signup/SignupModule.js"></script>
    <script src="/js/public/signup/SignupController.js"></script>

So there's that error but it doesn't seem to cause any problem, I just want to get rid of it..

Second issue is that everything is not in the middle of the screen like in your video. Probably a boostrap issue I guess, so everything is stretched, how do I make it fixed size? edit: this second issue is solved using the same bootstrap file as the one in the repos.

edit with a third issue: when I specify the compareTo module like at the end of the video I get TypeError: Cannot set property 'compareTo' of undefined. But this is probably linked to the first issue since the module doesn't seem to load properly

Hope you'll make ep4 soon = D thx

irlnathan commented 9 years ago

If you send me a link to your repo I'll take a look.

crislar commented 9 years ago

Taking the opportunity to give a big Thumbs up to the activityoverlord20!

thanks Christian

Irl Nathan wrote:

If you send me a link to your repo I'll take a look.

— Reply to this email directly or view it on GitHub https://github.com/irlnathan/activityoverlord20/issues/3#issuecomment-75869234.

Christian de Larrinaga

FBCS, CITP, MCMA

@ FirstHand

+44 7989 386778

cdel@firsthand.net

misterch0c commented 9 years ago

well seems the issue is always me, I resolved all those problems at the end of the day. Thank you though