search

irlnathan / activityoverlord20

This is an update to activityOverlord.
158 stars 52 forks source link

angular-toastr.js VS angular-toastr.tpls.js #4

Open edsfocci opened 9 years ago

edsfocci commented 9 years ago

Hi Irl,

So, now that it is May 2015, I experienced a problem with the updated angular-toastr. I've found that starting with version 1.0, we must now use angular-toastr.tpls.js instead, while angular-toastr.js is used if you want to use your own Toast templates (I received an error that /directive/toastr/toastr.html was missing when I used it).

I believe you are using version 0.5.2 from my search. I'm not sure if your intent was to support AngularJS 1.2, which would require version 0.4.2 instead, so I'm assuming you were trying to use the latest version at the time of the SailsCast video (ep. 3) Anyways, I'm just suggesting that we should use angular-toastr.tpls.js if using version 1.0 or later, in case someone gets confused in the future.

theorye commented 9 years ago

Ah so that's why toastr wasn't working. Thank you.

I hope he keeps going.

edsfocci commented 9 years ago

@theorye: I'm glad I can help :)