irmen / Pyro4

Pyro 4.x - Python remote objects
http://pyro4.readthedocs.io/
MIT License
713 stars 83 forks source link

PyroError "invalid uri" when using a unix socket with spaces in the file path #222

Closed samschott closed 5 years ago

samschott commented 5 years ago

When creating a daemon with a unix socket that has spaces in its file path, such as "/Users/samschott/Library/Application Support/myapp/myapp.sock" on macOS, registering a Pyro4 object fails with an "invalid uri" error.

This seems to happen because the regex which parses the uri does not allow whitespace in the location string. Is this behaviour intended or a bug?

irmen commented 5 years ago

I think there's no real reason not to allow spaces in the path. So I'll treat it as a bug .

samschott commented 5 years ago

Thanks for the quick response (and fix) time!