search

irmen / binaryen-interfaces

non-C programming language interfaces to the Binaryen library
11 stars 5 forks source link

Add install instructions to Python readme. #3

Closed dom96 closed 1 year ago

dom96 commented 1 year ago

Fixes #2

irmen commented 1 year ago

I'm not a huge fan of manually linking things in /usr/.. like you're suggesting, if there's a better alternative. By which I mean installing a binaryen package from your distro's packagemanager. For example, on Manjaro/ArchLinux there is the 'binaryen' community package that installs these files for you. Can you please modify this PR to suggest this first?

dom96 commented 1 year ago

Feel free to suggest changes and apply them, should be possible via GitHub's UI.

irmen commented 1 year ago

Wait, you can edit other author's files in a PR?

dom96 commented 1 year ago

Yep. If you try to add a comment to a line, the editor has an option to suggest a line change. If you do that and submit the comment with the suggestion you should be able to apply that suggestions afterwards, then squash and merge the PR.

irmen commented 1 year ago

Well, TIL. I have never seen or used this feature on Github yet!

dom96 commented 1 year ago

Updated. Feel free to squash merge.

irmen commented 1 year ago

looks good. thanks