Closed connectbo closed 3 years ago
If there is more than one replica and the replicas have different file sizes (regardless of their status, & or X...) then there is one icon per object/size combo in the icon view.
This is not the case for the regular browser list view - so we should consider how we want to display this scenario.
Goals:
@alanking might need your replica brain a little here
question is how can we get this information in the query itself? and/or how can bo filter his existing results to meet the goals listed above...
FWIW, the irods::experimental::filesystem
library has a data_object_size
function which takes the size of the last-written-to good replica. Here is the query used for that and how the results are handled: https://github.com/irods/irods/blob/4ee8cf8ec1c44b4a941b0c2364f3c1fb2cbfa950/lib/filesystem/src/filesystem.cpp#L585-L591 In that particular implementation, no size is given if the replica status is not good.
I refactored several components and enhance the error handling we have.
i like it - will render it here locally later today.
i see a branch conflict - need to rebase it cleanly.
i like it - will render it here locally later today.
i see a branch conflict - need to rebase it cleanly.
You are right, I didn't notice that when it's wip. Will fix it.
I think we are about ready for a squash with issue numbers... and we can get this merged. Don't # them yet.
merging into the main PR
This pr