175 thumbnail - Githubissues

irods-contrib / metalnx-web

Metalnx Web Application

https://metalnx.github.io/

BSD 3-Clause "New" or "Revised" License

36 stars 36 forks source link

175 thumbnail #229

Closed connectbo closed 3 years ago

connectbo commented 3 years ago

This pr

Refactored galleryview container and extract each item as component
Detect the type of each item from rule engine and render icon accordingly, whether it is collection or static file. Once we know how we generate and visit thumbnails, I can update its path so real thumbnails can be displayed
Clicking collection item will navigate user to that directory
Add navigation on the top path directory bar, just like the collection page
Add error handling when there is no irods rule engine or error occurs when fetching data

connectbo commented 3 years ago

Screen Shot 2021-05-04 at 4 03 50 PM

trel commented 3 years ago

If there is more than one replica and the replicas have different file sizes (regardless of their status, & or X...) then there is one icon per object/size combo in the icon view.

This is not the case for the regular browser list view - so we should consider how we want to display this scenario.

Goals:

only show one icon per logical data object
show size of 'good' replica if there are stales
show size of first stale replica if there are no good replicas

@alanking might need your replica brain a little here

question is how can we get this information in the query itself? and/or how can bo filter his existing results to meet the goals listed above...

alanking commented 3 years ago

FWIW, the irods::experimental::filesystem library has a data_object_size function which takes the size of the last-written-to good replica. Here is the query used for that and how the results are handled: https://github.com/irods/irods/blob/4ee8cf8ec1c44b4a941b0c2364f3c1fb2cbfa950/lib/filesystem/src/filesystem.cpp#L585-L591 In that particular implementation, no size is given if the replica status is not good.

connectbo commented 3 years ago

I refactored several components and enhance the error handling we have.

Polish path displaying (edge case: a long path)
Polish gallery item naming (edge case: use 'ellipsis' to handle a really long name)
Style error notifications inline with the collection browser. User will have the link to go back to collection browser. Attached two images if those would be helpful.

Screen Shot 2021-05-06 at 9 25 42 PM

Screen Shot 2021-05-06 at 9 03 25 PM

trel commented 3 years ago

i like it - will render it here locally later today.

i see a branch conflict - need to rebase it cleanly.

connectbo commented 3 years ago

i like it - will render it here locally later today.

i see a branch conflict - need to rebase it cleanly.

You are right, I didn't notice that when it's wip. Will fix it.

trel commented 3 years ago

I think we are about ready for a squash with issue numbers... and we can get this merged. Don't # them yet.

trel commented 3 years ago

merging into the main PR