irods-contrib / metalnx-web

Metalnx Web Application
https://metalnx.github.io/
BSD 3-Clause "New" or "Revised" License
36 stars 36 forks source link

Property based search in AVU search should not show all results - not more than granted permission rights #258

Closed mstfdkmn closed 2 years ago

mstfdkmn commented 3 years ago

Property based search in AVU search gives users (rodsuser) possibility to see other users’ all collection and data objects structure and name. To some extent this might be okay. But I think this is more than "needs to know principle". iCommands search by iquest doesn’t provide the same result. The iquest query works according to the granted access permissions.

Make the query based on the path parameter including a targeted user name:

image

See all the collections and data objects of the queried user. As seen, if the user who makes query has access right to any objects, those objects appear in a blue color and so that clickable:

image

You can see data objects as well:

image

However iCommands - iquest gives the results only for the objects that the query making user has access to.

iquest "%s/%s" "SELECT COLL_NAME, DATA_NAME where COLL_NAME like '%userName%'"

image

We think that extensive search options of Metalnx should work according to the access rights like what we have in other clients, i.e., iCommands. How do you evaluate this?

Note: Tested both in 4.2.8 - 2.4.0 and in 4.2.9 - 2.4.0 and the db is MySQL.

Thanks.

mstfdkmn commented 3 years ago

A minor point:

On this screen the column name "File Type" should be "Object Type" and the value "file" should be "data object" for the sake of consistency.

korydraughn commented 3 years ago

Please take a look at the following PR: https://github.com/irods-contrib/metalnx-web/pull/267

korydraughn commented 2 years ago

This issue can be closed due to #267.

trel commented 2 years ago

Ah, very nice.