search

irods-contrib / metalnx-web

Metalnx Web Application
https://metalnx.github.io/
BSD 3-Clause "New" or "Revised" License
36 stars 36 forks source link

Modify rename dialog header and layout #260

Closed connectbo closed 3 years ago

connectbo commented 3 years ago

This pr fixes this issue by modifying rename dialog. There are two pop ups to rename a collection mentioned in that issue. The second pop up was not the same as the first one.

After changes, clicking 'rename' button on collection info page will now take you to this dialog: (Notice I changed 'Add Collection' to 'Rename Collection', and added current path) image

I didn't change that name to 'Modify Collection' as the first popup, because there is an existing update inheritance modal on collection info page to handle permission inheritance. image

Let me know if that makes sense.

trel commented 3 years ago

I think that makes sense. Are there any other places where renames can occur? If this covers 2 of 2, I think we're good.

connectbo commented 3 years ago

I don't think there are other places renaming collection can occur - according to my latest metalnx knowledge :)

trel commented 3 years ago

did your editor make all these other changes? just whitespace / line length... they're a bit distracting - if it's easy to turn that kind of thing off... that'd be helpful. not required :)

connectbo commented 3 years ago

ah yes, code formatter made those changes. sorry about that, i will take care of this.

trel commented 3 years ago

ah, very good - thanks.

connectbo commented 3 years ago

I got rid off the changes code formatter did, will add # to it if that's looking good.

trel commented 3 years ago

yes, way more minimal - thanks.

connectbo commented 3 years ago

Both are changed to collections now. Should I add #?

trel commented 3 years ago

yep - looks good - please # it.