Closed connectbo closed 3 years ago
I think that makes sense. Are there any other places where renames can occur? If this covers 2 of 2, I think we're good.
I don't think there are other places renaming collection can occur - according to my latest metalnx knowledge :)
did your editor make all these other changes? just whitespace / line length... they're a bit distracting - if it's easy to turn that kind of thing off... that'd be helpful. not required :)
ah yes, code formatter made those changes. sorry about that, i will take care of this.
ah, very good - thanks.
I got rid off the changes code formatter did, will add # to it if that's looking good.
yes, way more minimal - thanks.
Both are changed to collections
now. Should I add #?
yep - looks good - please # it.
This pr fixes this issue by modifying rename dialog. There are two pop ups to rename a collection mentioned in that issue. The second pop up was not the same as the first one.
After changes, clicking 'rename' button on collection info page will now take you to this dialog: (Notice I changed 'Add Collection' to 'Rename Collection', and added current path)![image](https://user-images.githubusercontent.com/33065086/127333392-8fde0906-07a3-42e6-809b-3470a104f184.png)
I didn't change that name to 'Modify Collection' as the first popup, because there is an existing update inheritance modal on collection info page to handle permission inheritance.![image](https://user-images.githubusercontent.com/33065086/127333813-f8a383f7-61c2-443f-acd5-2891dcf4be33.png)
Let me know if that makes sense.