[251] Fix naming issue

[connectbo]

This pr fixes this naming issue when modifying data object.

First option renders like this now(from rename button in action dropdown):

Second option (from collectionInfo page):

[connectbo]

@trel Seems like I don't have the permission to add you as reviewer. It looks good on my end, please review.

[trel]

Can we make both rename actions use the same dialog box?

And I think they should both look like the first option...

• dialog title should be 'Rename Data Object'
• 'Parent Collection' - can't be edited by the user
• 'Data Object Name' - text box

If there is a dialog for renaming a Collection... that should be consistent as well.

• dialog title should be 'Rename Collection'
• 'Parent Collection' - can't be edited by the user
• 'Collection Name' - text box

[connectbo]

Sure, that makes sense. I will poke around and make changes.

[connectbo]

Alright, dialog box looks like this now. Let me know if these look good:

rename option 1 (from rename button in action dropdown):

• collection:

• data object:

rename option 2 (from collectionInfo page):

• collection:

• data object:

The only difference on these dialog boxes is the inheritance section when renaming collections, option 2 doesn't have that. I suspect that it is because there is already an inheritance checkbox on collectionInfo page.

[trel]

'Data Object Name' instead of 'File name'

I'll play with the Inheritance setting and see how it should work.

[connectbo]

Ahh yes, sorry about that, missed that part. Should be correct now.

[trel]

I confirm you didn't touch any of the Inheritance stuff - let's leave it as is for now - even though I'm not sure why that checkbox is in that location on one of the dialogs... separate issue...

Yes, please # it and we'll get it merged - thanks.

[connectbo]

Done.