irods-contrib / metalnx-web

Metalnx Web Application
https://metalnx.github.io/
BSD 3-Clause "New" or "Revised" License
36 stars 36 forks source link

New popup on login page for restricted use message #301

Open connectbo opened 2 years ago

connectbo commented 2 years ago

This pr includes 1) new popup for restricted use message and 2) fix some positioning bug in the login wrapper

image

trel commented 2 years ago

ping @justinkylejames

connectbo commented 2 years ago

yep thanks. Justin, let me know if any changes are needed.

trel commented 2 years ago

Consider a configuration setting... metalnx.login.popup=true?

(perhaps even the whole string could be a configuration... metalnx.login.popup.message=...)

Oh, could just test to see if the string is not-empty... and show it... we'd default to empty.

Won't be merging into the main branch as-is.

JustinKyleJames commented 2 years ago

In my case the login page will never show so I'll have to rework that a bit but this is very good. It should give me enough to do what I need.