search

irods-contrib / metalnx-web

Metalnx Web Application
https://metalnx.github.io/
BSD 3-Clause "New" or "Revised" License
36 stars 36 forks source link

Issue 294 #346

Closed JustinKyleJames closed 1 year ago

JustinKyleJames commented 1 year ago

This is to fix #294. We will investigate separately why instantiating and closing these objects more than once causes failure with SSL but for now this fixes the problem.

Also note that this can supersede pull request #345 as I have that commit in here as well. If you prefer to do this as two pull requests that each have only one commit let me know.

korydraughn commented 1 year ago

Does search return results that contain a mixture of data objects and collections? Does it page through the results correctly?

trel commented 1 year ago

yes, let's get 345 in first / separately - and then this one will be standalone.

JustinKyleJames commented 1 year ago

Does search return results that contain a mixture of data objects and collections? Does it page through the results correctly?

From my testing, yes on both. It does have a mixture and I was able to page through.

JustinKyleJames commented 1 year ago

Just to add from above. I created 100 files and 100 collections. Added metadata on each. Did owner searches (returned all 200+ entries), metadata searches, etc.

I also did all of the above with a non admin account.

korydraughn commented 1 year ago

Excellent!

JustinKyleJames commented 1 year ago

Let's get https://github.com/irods-contrib/metalnx-web/pull/345 merged first like @trel said. Then we can rebase and merge this PR.

I went ahead and rebased on #345 after the pound was added.

JustinKyleJames commented 1 year ago

This has been rebased on top of main.

JustinKyleJames commented 1 year ago

Looks good. Let's add the pound.

Done