Closed korydraughn closed 1 year ago
compilation failure
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project metalnx-web: Compilation failure
[ERROR] /usr/src/mymaven/metalnx-web/src/main/java/com/emc/metalnx/controller/BrowseController.java:[542,35] method createCollection in interface com.emc.metalnx.services.interfaces.CollectionService cannot be applied to given types;
[ERROR] required: com.emc.metalnx.core.domain.entity.DataGridCollectionAndDataObject
[ERROR] found: com.emc.metalnx.core.domain.entity.DataGridCollectionAndDataObject,boolean
[ERROR] reason: actual and formal argument lists differ in length
You're going to have to compile and install jargon-irods-ext. You need @JustinKyleJames' latest commits.
Ah, need more machinery.
Don't forget - you're going to need to instruct the build to install the artifacts into the same repository used to build metalnx.
I tested this and verified that when multiple files are selected, the download is a proper tar file.
I also tested both the creation of a collection with parent collections and metadata additions.
@JustinKyleJames Good. What we need to do now is watch/help someone (whose not familiar with Java/Maven) build Metalnx and do these operations.
@trel Perhaps, you (with my help) can try it tomorrow?
certainly.
Bumping the version of Jargon is not enough.
To verify the results, I had to compile specific branches of various projects.
Using an older maven docker image (i.e. maven:3-jdk-11) and using an empty directory as the local maven repository, I was able to compile all projects and guarantee that they use the correct jar files. (I learned you can't compile jargon-irods-ext using maven:3.8.4-openjdk-17 due to API compatibility issues with the version of jaxb2.)
We need to release new versions of jargon and jargon-irods-ext which include the changes recently introduced by @JustinKyleJames before we can release metalnx. However, the jargon changes @JustinKyleJames made exist only on the development branch of jargon and I'm not sure how the branches of jargon relate to each other.
@michael-conway Thoughts?
I've confirmed that this PR is now ready for merging.
All the necessary changes for Jargon are now available and the changes introduced by @JustinKyleJames work as expected.
Taking out of draft and adding the pound.
This PR now addresses the following issues:
Verified that bumping the version of Jargon resolves the TAR file extension issue.
Someone else needs to test this PR before we merge it.
Leaving as a draft PR until then.