Pass upstream error, not SUCCESS() in case of problem with file put in msiput_dataobj_or_coll

irods / contrib

A pooled collection of community-contributed code that works alongside iRODS

BSD 3-Clause "New" or "Revised" License

13 stars 19 forks source link

Pass upstream error, not SUCCESS() in case of problem with file put in msiput_dataobj_or_coll #24

Closed PaulVanSchayck closed 6 years ago

PaulVanSchayck commented 6 years ago

There is a typo in the error handling code of this microservice. Upon error of the put_a_file() function (which uses rcDataObjPut() in turn), the error was not propagated downstream because final_error was set to SUCCESS() by default. Change this to ret which contains the upstream error.

trel commented 6 years ago

thanks!