search

irods / irods_capability_automated_ingest

Other
12 stars 15 forks source link

black formatter - no functional changes #179

Closed trel closed 8 months ago

trel commented 2 years ago

has not been tested...

posting for discush

trel commented 1 year ago

@d-w-moore please run this branch through the test framework

d-w-moore commented 1 year ago

@d-w-moore please run this branch through the test framework

Tests passed in https://github.com/d-w-moore/irods_capability_automated_ingest/tree/blackish. An extra commit was necessary to force 4.2.11 rather than the current package-install default (4.3.0) of iRODS, as the provider to be tested against.

So this PR should probably wait to be merged, until after #176 (which includes the equivalent of the above-mentioned irods_version forcing commit.)

trel commented 1 year ago

Ah, very nice. One point for black.

d-w-moore commented 1 year ago

Next stop, PRC

trel commented 8 months ago

176 was merged 15mo ago - so refreshing/rebasing...

trel commented 8 months ago

updated, will need to be tested again.

alanking commented 8 months ago

There are currently 7 tests failing on tip of main (sans these changes):

FAIL: test_put (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_put)    
FAIL: test_put_append (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_put_append)
FAIL: test_put_sync (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_put_sync)
FAIL: test_register (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_register)
FAIL: test_update_metadata (irods_capability_automated_ingest.test.test_irods_sync.Test_update_metadata.test_update_metadata)
FAIL: test_update_metadata_root_with_resc_name (irods_capability_automated_ingest.test.test_irods_sync.Test_update_metadata.test_update_metadata_root_with_resc_name)
FAIL: test_update_metadata_with_resc_name (irods_capability_automated_ingest.test.test_irods_sync.Test_update_metadata.test_update_metadata_with_resc_name)
alanking commented 8 months ago

Happily, the same 7 tests fail with these changes.

alanking commented 8 months ago

Let's link this to #180 and get it in.

trel commented 8 months ago

done and #'d.