Closed trel closed 8 months ago
@d-w-moore please run this branch through the test framework
@d-w-moore please run this branch through the test framework
Tests passed in https://github.com/d-w-moore/irods_capability_automated_ingest/tree/blackish. An extra commit was necessary to force 4.2.11 rather than the current package-install default (4.3.0) of iRODS, as the provider to be tested against.
So this PR should probably wait to be merged, until after #176 (which includes the equivalent of the above-mentioned irods_version
forcing commit.)
Ah, very nice. One point for black.
Next stop, PRC
updated, will need to be tested again.
There are currently 7 tests failing on tip of main (sans these changes):
FAIL: test_put (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_put)
FAIL: test_put_append (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_put_append)
FAIL: test_put_sync (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_put_sync)
FAIL: test_register (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_register)
FAIL: test_update_metadata (irods_capability_automated_ingest.test.test_irods_sync.Test_update_metadata.test_update_metadata)
FAIL: test_update_metadata_root_with_resc_name (irods_capability_automated_ingest.test.test_irods_sync.Test_update_metadata.test_update_metadata_root_with_resc_name)
FAIL: test_update_metadata_with_resc_name (irods_capability_automated_ingest.test.test_irods_sync.Test_update_metadata.test_update_metadata_with_resc_name)
Happily, the same 7 tests fail with these changes.
Let's link this to #180 and get it in.
done and #'d.
has not been tested...
posting for discush