irods / irods_capability_automated_ingest

Other
12 stars 15 forks source link

Investigate failing tests #215

Closed alanking closed 2 months ago

alanking commented 6 months ago

The following 7 tests are currently failing on tip of main. These should be resolved before the next release.

FAIL: test_put (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_put)    
FAIL: test_put_append (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_put_append)
FAIL: test_put_sync (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_put_sync)
FAIL: test_register (irods_capability_automated_ingest.test.test_irods_sync.Test_irods_sync_UnicodeEncodeError.test_register)
FAIL: test_update_metadata (irods_capability_automated_ingest.test.test_irods_sync.Test_update_metadata.test_update_metadata)
FAIL: test_update_metadata_root_with_resc_name (irods_capability_automated_ingest.test.test_irods_sync.Test_update_metadata.test_update_metadata_root_with_resc_name)
FAIL: test_update_metadata_with_resc_name (irods_capability_automated_ingest.test.test_irods_sync.Test_update_metadata.test_update_metadata_with_resc_name)
alanking commented 2 months ago

See #219 for possible hint as to why this may be happening...

219 is not related.

alanking commented 2 months ago

The tests are failing due to some string concatenation that is failing due to some constituent parts not being strings but bytes... This is resolved by using f-strings or str.format.

alanking commented 2 months ago

For completeness... some of the changes made for #207 did not update all the interfaces as required so those need to be fixed up as well.

alanking commented 2 months ago

Tests are now passing.