search

irods / irods_capability_automated_ingest

Other
12 stars 16 forks source link

New Celery app, remove kubernetes / flask, update tests to iRODS 4.3.3 #267

Closed alanking closed 3 weeks ago

alanking commented 1 month ago

Addresses #211 Addresses #262 Addresses #269 Addresses #272 Addresses #274

Some notes on this PR...

  1. Main test suite is passing.
  2. I have not tested S3 yet.
  3. The existing Celery application and many of its constellation of files have been removed.

I don't think we need any new tests because the goal is for the new implementation to be identical in behavior to the old implementation besides having new Celery application and task names.

Also, I realize this is a big change, so here's a few areas where eyeballs are most needed (IMO):

Will leave in draft til I can test with S3.

alanking commented 1 month ago

Ah yes. I'll run black just before we # this because it's going to make rebasing very tricky later should I need to squash things.

alanking commented 1 month ago

Nevermind, I found a way to thread the needle. Had to run the formatter on the test suite before new changes came in and things work out pretty cleanly. Force-pushed because still in draft. Will test S3 shortly...

trel commented 1 month ago

nice.

alanking commented 1 month ago

Had to make a tweak and then was able to successfully sync an S3 bucket with Minio in the demo Docker Compose project. So, I guess this is ready for review.

alanking commented 1 month ago

Caught an issue in the latest changes... Tests are passing again.

alanking commented 1 month ago

Tests are passing with latest changes

alanking commented 1 month ago

Rebased and squashed. Didn't mean to push, though. Sorry about that, reviewers...

trel commented 1 month ago

very shady.

korydraughn commented 3 weeks ago

We got an approval from @FifthPotato.

Do you feel this is ready for squashing/merging? Is there anything else left to do for this PR?

alanking commented 3 weeks ago

I think this is ready. The goal was to keep the behavior unchanged as much as possible and the tests are passing, so I think adding anything else in this PR is unnecessary if we're all good with the existing changes.

korydraughn commented 3 weeks ago

Sounds good to me.

Please squash to taste.

alanking commented 3 weeks ago

Squashed

alanking commented 3 weeks ago

'd, mergin