alanking commented 3 years ago

Due to some changes in how scheduling data migrations works, the unified storage tiering REP needed to be updated in order to work. The following changes were made:

"policy" was changed to "policy_to_invoke" as expected in the cpp default REP implementation of irods_policy_enqueue_rule
"payload" was changed to "parameters" as expected in the cpp default REP implementation of irods_policy_enqueue_rule
"delay_conditions" was moved inside of the "parameters" JSON struct as expected in the cpp default REP implementation of irods_policy_enqueue_rule

This causes everything to align as expected in the new world of policy-composed rule invocation.

CI tests running, but all tests passed at the bench. Fixed all of the log noise that I observed while running at the bench as well.

trel commented 3 years ago

very nice - please # em up.

alanking commented 3 years ago

'd

trel commented 3 years ago

and for master too so we don't lose them...

edit: oh, you said only 4-2-stable...

alanking commented 3 years ago

Right, it looks like master needs a few things to be cherry-picked over. I can go ahead and do that if you want. Otherwise I will just close the linked issue.

trel commented 3 years ago

just make a new issue to remember to grab some things if time is tight

alanking commented 3 years ago

I created #167 for the work to be done on master branch

irods / irods_capability_storage_tiering

[#165] Fix scheduled migration via default cpp REP (4-2-stable) #166

'd