Closed alanking closed 2 years ago
Okay, we have confirmed that the issue is in the delay server and I am working on a fix for this now: irods/irods#6323
I'd still like to see the tests pass before I merge this but I will mark as ready for review.
Are you referring to test_mode=True
in the restart
calls? This is restarting the server in test mode which is a special mode in 4.3.0 to handle the differences in logging between the past and the future. Any test relying on log messages needs to use test mode when starting the server. I think we always restart the server in test mode in the main repo for the test suite.
okay, so then... where did the extra REPs get to? just big minus?
The extra REPs are only applicable in policy-composed storage tiering. The unified storage tiering REP contains all of these rule engine plugins in the same shared object so there is no need to install or configure them separately. Many of the diffs from the test file are a result of literally copying the file from 4-2-stable and pasting into main.
ooooh, right.
I created #193 to address my remaining concerns, but this set of changes has produced success in getting the tests to pass in conjunction with irods/irods#6325.
these look good to me.
Should we go ahead and get this in, then? I'll ping @korydraughn in case he has thoughts.
I vote green, #, and push em.
Same here. If it's green, let's go on and merge it.
Okey dokey. Thanks
These tests do NOT pass presently. I suspect there is a bug in the delay server as the tests do pass in 4-2-stable. If you diff this against 4-2-stable, you will see that the only difference of any possible consequence is the fetching of configuration values, and I don't think that is related to the issues I am seeing. I could be wrong, of course. :) Leaving as draft until we can figure it out.