Incorrect string comparison

korydraughn commented 2 years ago

[x] main

[x] 4-2-stable

Observed while building package for 4.3.0.

17:33PM kory@kdd-ws:~/dev/prog/cpp/build_storage_tiering $ ninja package
[2/7] Building CXX object CMakeFiles/irods_rule_engine_plugin-unified_storage_tiering.dir/storage_tiering_utilities.cpp.o
/home/kory/dev/prog/cpp/irods_capability_storage_tiering/storage_tiering_utilities.cpp:15:26: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
        if(msp->type == STR_MS_T) {                                                                                                        
                     ^  ~~~~~~~~                                                                                         
1 warning generated.                                                                                
[6/7] Run CPack packaging tool...                 
CPack: Create package using DEB   
CPack: Install projects                  
CPack: - Install project: irods_capability-storage_tiering []                              
CPack: Create package            
CPack: - package: /home/kory/dev/prog/cpp/build_storage_tiering/irods-rule-engine-plugin-unified-storage-tiering_4.3.0.0-1~bionic_amd64.deb generated.

korydraughn commented 2 years ago

We should cherry pick the fix for this to 4-2-stable if it has the same problem.

Will verify.

korydraughn commented 2 years ago

Same issue is in 4-2-stable.

irods / irods_capability_storage_tiering

Incorrect string comparison #197

[x] 4-2-stable