search

irods / irods_capability_storage_tiering

BSD 3-Clause "New" or "Revised" License
5 stars 10 forks source link

Various fixes and improvements (main) #243

Closed alanking closed 7 months ago

alanking commented 7 months ago

Supersedes #236

Addresses #191, #229, #235, #237, #239, #241

All the new tests pass. Running full test suite now.

alanking commented 7 months ago

The whole test suite passed before these last few changes.

The latest changes are only renaming a function (the project still successfully builds) and updating comments and the README. So, I'll re-run the test suite again when an actual behavioral change occurs. Maybe just in case right before merging.

Also, sneaking #154 in, for kicks.

korydraughn commented 7 months ago

If everything compiles and the tests pass, let's squash and get it merged.

alanking commented 7 months ago

Gonna run tests one more time for sanity. Also, might yield to #234 to avoid dealing with the conflict in that branch but rather deal with it here in this branch.

alanking commented 7 months ago

Tests passed.

korydraughn commented 7 months ago

Squash when ready.

alanking commented 7 months ago

One of the new tests added in #234 is failing with my changes because it is restaging an object to a higher tier (which is now disallowed). I will need to update the test.

trel commented 7 months ago

oh, the test itself is doing that? interesting.

alanking commented 7 months ago

Had to force-push due to rebase, but only the latest commit reflects new changes. The aforementioned test now passes. I had to make sure that the spirit of the test was maintained and that it was not also duplicating a test that I added in this PR. I think the needle has been threaded.

Running all the tests once more.

alanking commented 7 months ago

Well... test_plugin_unified_storage_tiering.TestStorageTieringContinueInxMigration.test_put_object_limit_lt failed, but succeeded after running again. Might be non-deterministic. Trying a few more times to see what kind of results I get.

alanking commented 7 months ago

I tried running the test 10 times in a row. The first 5 times it passed with similar times (~130 seconds). The 6th time has been running for over 20 minutes and I'm pretty sure it is never going to pass based on the assertion that it's stuck on. It appears that it tiered out 4 objects and stopped, not scheduling any more to tier out (there are 256 objects that need to be tiered out).

I'm going to try this again without my commits to see if anything changes.

alanking commented 7 months ago

I observed similar behavior with the commit upon which these changes are based, so I filed an issue for that test here: https://github.com/irods/irods_capability_storage_tiering/issues/246

Will await approval / confirmation to move forward before merging, just in case.