search

irods / irods_client_globus_connector

The iRODS Globus Connector
2 stars 4 forks source link

Issue 73 #100

Closed JustinKyleJames closed 4 months ago

JustinKyleJames commented 4 months ago

Opening in draft mode while I figure out how to test this.

Ignore commit for issue 65 as this will be rebased on that once its pull request is finished.

JustinKyleJames commented 4 months ago

I got help from Globus on how to test this. I added a test case for it.

JustinKyleJames commented 4 months ago

I rebased this on main after issue 65 was merged.

trel commented 4 months ago

looks good - this passes the tests?

are you going to squash to one? or two (code+test)?

JustinKyleJames commented 4 months ago

looks good - this passes the tests?

are you going to squash to one? or two (code+test)?

Yes, it passes the tests. I'll squash to one I think.

trel commented 4 months ago

Seems good.

JustinKyleJames commented 4 months ago

I squashed with no pound.

trel commented 4 months ago

yep - i think we're ready for undrafting and some @alanking eyeballs.

JustinKyleJames commented 4 months ago

I updated the commit message to state "preserve file modification time" instead of "preserve replica". I think my brain was on autopilot when I wrote the original message.

korydraughn commented 4 months ago

If the tests pass, let's squash it.

JustinKyleJames commented 4 months ago

If the tests pass, let's squash it.

done

JustinKyleJames commented 4 months ago

Please pound if ready.

done