search

irods / irods_client_globus_connector

The iRODS Globus Connector
2 stars 4 forks source link

Issue 55 #56

Closed JustinKyleJames closed 1 year ago

JustinKyleJames commented 1 year ago

This is to fix the base64 encoding issue. The second commit is basically just pulling irods clientLogin() into the project. The final is updates to this method to force legacy authentication.

I did not run clang-format so as not to confuse what was changed from the original login code pulled from the iRODS core.

Finally, this will be pulled from the 4.3.1.0 as it won't be necessary when iRODS 4.3.1 is released.

trel commented 1 year ago

Looks good to me - does it compile and pass tests against a 4.3.0 iRODS server?

If so, please # the last two commits and we'll get it merged and released.

JustinKyleJames commented 1 year ago

Can we leave some comments (in the code and/or in commit messages) or open an issue or something to explain the existence of this function? I realize this is only going into 4-3-0-stable and we have this PR for context, but it could be nice for future selves. :)

I added comments. It is a bit repetitive as it has much of the same information at the top of the file and before the irods_globus_clientLogin() method.

JustinKyleJames commented 1 year ago

I think these comments are great. Thanks!

If appropriate tests are passing, I say squash to taste

Done. Please take a final look and I will pound.

JustinKyleJames commented 1 year ago

Yep, let's # it

Done.