search

irods / irods_client_globus_connector

The iRODS Globus Connector
2 stars 4 forks source link

Issue 59 - Update build instructions and update debian ssl version #60

Closed JustinKyleJames closed 1 year ago

korydraughn commented 1 year ago

Is this ready for review?

If not, consider converting this to draft so no one attempts to review it before it's ready.

JustinKyleJames commented 1 year ago

Is this ready for review?

If not, consider converting this to draft so no one attempts to review it before it's ready.

I converted it to draft. Terrell was going to use it to build the packages so I'll wait to see if it works for him.

These steps did work for me but in a Dockerfile.

JustinKyleJames commented 1 year ago

Since this hasn't been reviewed I squashed the three commits into one and forced push.

korydraughn commented 1 year ago

Looks good to me. Anything else left for this PR?

JustinKyleJames commented 1 year ago

No, there is nothing left for this PR. It is ready to go and tested in all OS's.

korydraughn commented 1 year ago

If you're happy with the changes, please squash and leave off the pounds so we can eyeball it one last time.

JustinKyleJames commented 1 year ago

Squash has been done.

trel commented 1 year ago

the readme commit message mentions wget - but there is no wget in the diff. otherwise, i think this is good/ready.

JustinKyleJames commented 1 year ago

the readme commit message mentions wget - but there is no wget in the diff. otherwise, i think this is good/ready.

There was a wget added and then updated which was lost on the squash. I will remove that note.

trel commented 1 year ago

i think we're good to go. please # them both.

JustinKyleJames commented 1 year ago

i think we're good to go. please # them both.

Done