Closed JustinKyleJames closed 1 year ago
4-2-stable still uses clang6 and cmake3.11 and jansson i think...
I think we removed the dependency on jansson. It's possible some other 4.2 project still relies on it.
I tested with clang6 and cmake3.11 and updated this pull request accordingly.
I added the jansson package install back in because it is in the CMakeLists.txt. I don't believe this is required and have opened an issue (#64) on it but I don't think that is necessary for this pull request.
Note that this has already been removed and tested in 4.3.
Also note that the irods-dev* in the following lines needs to be altered for the specific version. If you just do it as is it will upgrade to 4.3 which is not what a person would want who is building for 4.2.x.
sudo apt-get -y install irods-externals-cmake3.11.4-0 irods-externals-clang6.0-0 irods-externals-jansson2.7-0 irods-dev irods-runtime
sudo yum -y install irods-externals-cmake3.11.4-0 irods-externals-clang6.0-0 irods-externals-jansson2.7-0 irods-devel irods-runtime rpm-build
Should we update these to the following:
sudo apt-get -y install irods-externals-cmake3.11.4-0 irods-externals-clang6.0-0 irods-externals-jansson2.7-0 irods-dev=<version> irods-runtime=<version>
sudo yum -y install irods-externals-cmake3.11.4-0 irods-externals-clang6.0-0 irods-externals-jansson2.7-0 irods-devel-<version> irods-runtime-<version> rpm-build
Maybe a note that if you are building for the latest irods version the irods-dev(el) doesn't need a version attached.
I updated the README to have the version selected for irods-dev(el) and irods-runtime.
Note that from debian I had to add a wildcard since the OS version is in the version string.
i see it.
does the asterisk work as expected/designed? from a repo?
Yes, it does.
From: Terrell Russell @.> Sent: Thursday, March 30, 2023 2:51 PM To: irods/irods_client_globus_connector @.> Cc: James, Justin Kyle @.>; Author @.> Subject: Re: [irods/irods_client_globus_connector] [59] Update README for yum build instructions (PR #63)
i see it.
does the asterisk work as expected/designed? from a repo?
— Reply to this email directly, view it on GitHubhttps://github.com/irods/irods_client_globus_connector/pull/63#issuecomment-1490774442, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXBOHQNCTWI4JD4472O2GDW6XI4RANCNFSM6AAAAAAWNKYAIQ. You are receiving this because you authored the thread.Message ID: @.***>
got it - please squash to one.
got it - please squash to one.
done
good good - please # it.
@JustinKyleJames please # this commit
I just pounded this. Sorry about the delay.
merging.
Several Updates: