Implementing optional parameter for all endpoints - Githubissues

irods / irods_client_http_java

test wrapper for iRODS HTTP API

0 stars 1 forks source link

Implementing optional parameter for all endpoints #43

Closed sam-i-am012 closed 3 months ago

sam-i-am012 commented 3 months ago

Addresses #29

trel commented 3 months ago

consider separating the .idea files removal from the optional parameter commits.

not a blocker.

sam-i-am012 commented 3 months ago

I've resolved all existent comments and am awaiting further review.

korydraughn commented 3 months ago

Is everything as you expect it? Is there anything else left to do for this PR?

korydraughn commented 3 months ago

And do the tests pass?

sam-i-am012 commented 3 months ago

Yep, all tests that are currently present pass. That should be it for this PR.

korydraughn commented 3 months ago

Squash to taste and pound it.

korydraughn commented 3 months ago

I see one commit is missing an issue number.

sam-i-am012 commented 3 months ago

Done.

korydraughn commented 3 months ago

Excellent.

Merging.