search

irods / irods_client_http_java

test wrapper for iRODS HTTP API
0 stars 1 forks source link

Convert method names in endpoints to camel case #49

Closed sam-i-am012 closed 3 months ago

sam-i-am012 commented 3 months ago

Addresses #36

sam-i-am012 commented 3 months ago

Comment has been resolved!

korydraughn commented 3 months ago

When you make changes based on code review comments, avoid squashing them. Instead, push the new commit to the PR. Doing that allows us to see what changed since the last commits. You can come up with a scheme for determining how things should be squashed. For example, the commit that will be squashed later could be worded like so:

squash w/ 42. code review - renamed genquery to GenQuery.

Then, when all code reviewers agree that things are good, you squash things down. Remember, you can change the order of the commits during a rebase. If you're uncomfortable with doing that, let me know and I'll show you.

korydraughn commented 3 months ago

Do the tests still pass?

sam-i-am012 commented 3 months ago

Ah okay that makes sense, thank you. Yes, the tests do still pass.

sam-i-am012 commented 3 months ago

Done.

korydraughn commented 3 months ago

It looks like these commits could be squashed to one. It's not obvious to me why they're separate. Please explain.

sam-i-am012 commented 3 months ago

Everything has been squashed down.

korydraughn commented 3 months ago

Merging.