search

irods / irods_client_http_java

test wrapper for iRODS HTTP API
0 stars 1 forks source link

[83] Rename packages to be lowercase #84

Closed sam-i-am012 closed 2 months ago

sam-i-am012 commented 2 months ago

Yep all tests pass, I've edited the commit message.

sam-i-am012 commented 2 months ago

Done.

korydraughn commented 2 months ago

Github is reporting several conflicts. Please resolve.

sam-i-am012 commented 2 months ago

This PR may be deleted because I think I messed something up with rebase and I think it'll be easier if I switch over to my backup of this branch and start fresh.

sam-i-am012 commented 2 months ago

Okay, I resolved the conflicting changes. It was mostly due to me adding files in main from the previous PR that was merged where the packages where still capitalized so all I had to do change them to lowercase. All tests pass.

sam-i-am012 commented 2 months ago

All existing review comments have been resolved.

korydraughn commented 2 months ago

If the tests pass and you're happy with it, squash it to one commit and we'll get it merged.

sam-i-am012 commented 2 months ago

Done, all tests pass.

korydraughn commented 2 months ago

Merging.