search

irods / irods_client_library_rirods

rirods R Package
https://rirods.irods4r.org
Other
6 stars 5 forks source link

add flexibility for remote servers #5

Closed MartinSchobben closed 1 year ago

MartinSchobben commented 1 year ago

I added in this update more flexibility that accommodates connecting to remote servers. This was missing as testing beforehand only used a local server (irods_demo). This patch also introduces flexible testing for remote and local servers. This workflow is described in the vignette: https://martinschobben.github.io/irods_client_library_rirods/articles/develop.html.

MartinSchobben commented 1 year ago

I am pretty sure those values can only be found in the documentation. In the whole testing infrastructure I use environmental variables. I get the same result when testing against the demo and the UU server. I might be mistaken but I don't see it right now.

trel commented 1 year ago

Are you happy with this at the moment? Anything to do before merging to main?

MartinSchobben commented 1 year ago

I believe it is good to go now. This PR got a bit messy because after a few days I realized that my idea for more automated testing could be implemented in a much simpler way. I also sneaked in some minor tweaks that in theory makes it possible to get the package accepted at CRAN.

trel commented 1 year ago

sounds great - merging - and we'll go from here.